Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #3813] Removing Quarkus Configuration From Springboot file #3840

Merged
merged 2 commits into from
Feb 10, 2025
Merged

[Fix #3813] Removing Quarkus Configuration From Springboot file #3840

merged 2 commits into from
Feb 10, 2025

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Feb 6, 2025 •
edited
Loading

As part of resolution of #3813, a misleading application.properties should be changed

@gmunozfe
Copy link
Contributor

gmunozfe commented Feb 7, 2025

Looks good to me, kogito.events.usertaskinstances.topic might also work, but it's fine as it is.
Good work @fjtirado !

@fjtirado fjtirado requested a review from pefernan February 7, 2025 10:47
@fjtirado
Copy link
Contributor Author

fjtirado commented Feb 7, 2025

As @pefernan realized, events are already configurable by using kogito.addon.events.process.kafka.kogito-processinstances-events.topic=the topic

@fjtirado fjtirado closed this Feb 7, 2025
@fjtirado fjtirado reopened this Feb 7, 2025
@fjtirado fjtirado force-pushed the Fix_#3813 branch 4 times, most recently from 2a184e2 to fe43cac Compare February 7, 2025 17:09
pefernan
pefernan approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, thank you @fjtirado

...ration-tests/integration-tests-springboot-kafka-it/src/main/resources/application.properties Outdated Show resolved Hide resolved
@fjtirado @pefernan
Update springboot/integration-tests/integration-tests-springboot-kafk…
04ab539 
…a-it/src/main/resources/application.properties

Co-authored-by: Pere Fernández <[email protected]>
@fjtirado fjtirado changed the title [Fix #3813] Allowing configuration of output topic for internal events [Fix #3813] Removing Quarkus Configuration From Springboot file Feb 7, 2025
@pefernan
Copy link
Contributor

pefernan commented Feb 7, 2025

Perfect man :)

@kie-ci3
Copy link
Contributor

kie-ci3 commented Feb 7, 2025

PR job #10 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3840 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3840/10/display/redirect

Test results:

  • PASSED: 3544
  • FAILED: 1

Those are the test failures:

org.kie.kogito.codegen.tests.PublishEventIT.testExclusiveGatewayStartToEnd
expected: "ExclusiveSplit"
but was: "defaultPackage.TimerProcess"

@fjtirado fjtirado merged commit 982e5c4 into main Feb 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe approved these changes

@pefernan pefernan pefernan approved these changes

@elguardian elguardian Awaiting requested review from elguardian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fjtirado @gmunozfe @pefernan @kie-ci3